Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth-lib dependency updated #3242

Merged
merged 4 commits into from
Nov 28, 2019
Merged

eth-lib dependency updated #3242

merged 4 commits into from
Nov 28, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Nov 26, 2019

Description

This PR does define the eth-lib dependency as a dynamic version starting from 0.2.8.

Type of change

  • Dependencies

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success and extended the tests if necessary.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@nivida nivida added dependencies 1.x 1.0 related issues labels Nov 26, 2019
@nivida nivida requested a review from cgewecke November 26, 2019 13:53
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.485% when pulling 59967b5 on dependencies/updating-of-eth-lib into e914ec3 on 1.x.

@nivida nivida added the Review Needed Maintainer(s) need to review label Nov 28, 2019
@nivida
Copy link
Contributor Author

nivida commented Nov 28, 2019

@cgewecke I've merged this PR which does define a dynamic version for the eth-lib dependency in the package.json of the web3-eth-accountspackage. This because eth-lib is managed by Everton from the EF JS Team which web3.js is a part of. Sorry for all the notifications you got for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants