Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wyatt/update beaconchain tests #3825

Merged
merged 5 commits into from
Dec 24, 2020
Merged

Conversation

spacesailor24
Copy link
Contributor

Description

  • Adds Axios.defaults.adapter = require('axios/lib/adapters/http'); to base ETH2 class
    • This may need to be removed, but it was the only solution I found to a CORS error I was getting trying to query a local Lighthouse node
  • Adds lighthouse-docker command to MakeFile
  • Removes notImplemented flag from Beacon Chain schema
  • Updates previously not implemented Beacon Chain schema tests

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.034% when pulling 12c2820 on wyatt/update-beaconchain-tests into 27c9679 on 1.x.

@spacesailor24 spacesailor24 merged commit 4469516 into 1.x Dec 24, 2020
@spacesailor24 spacesailor24 deleted the wyatt/update-beaconchain-tests branch December 24, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants