Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bignumber.js broken dependency #905

Merged
merged 1 commit into from
Jun 24, 2017
Merged

Conversation

shayanb
Copy link
Contributor

@shayanb shayanb commented Jun 23, 2017

fix for reported issue: #904

@shayanb shayanb mentioned this pull request Jun 23, 2017
@shayanb
Copy link
Contributor Author

shayanb commented Jun 23, 2017

All tests passed!
660 passing (535ms)

@highruned
Copy link

Ship it! :shipit:

@tochie
Copy link

tochie commented Jun 23, 2017

Let's ship this. web3 is broken!

@MitchK
Copy link

MitchK commented Jun 24, 2017

Need asap, it's breaking our builds

@frozeman
Copy link
Contributor

Why is trstrpc using develop?!

@jeffscottward
Copy link

Can we get this up to NPM asap. Blocked still.

@tochie
Copy link

tochie commented Jun 25, 2017

Testrpc should not be using develop. It should be stable. People can't get halted by someone's experiment.

@imosdevteam
Copy link

I believe that this dep broke various truffle npm packages - so basically the whole toolchain - testrpc, truffle-*, web3

@cnilesh
Copy link

cnilesh commented Jun 25, 2017

Guess it does break while installing embark too...npm -g install embark

@highruned
Copy link

highruned commented Jun 25, 2017

Yeah... deps to specific commits/branches maybe shouldn't have been in master
embarklabs/embark#281

@tcoulter
Copy link

Hi all. Regarding Truffle and TestRPC issues as a result of this error:

We've been working very hard over the last couple weeks to completely remove this and all future installation issues from the TestRPC, as well as Truffle. Please see the following two blog posts for a description of what we're doing:

The TL;DR version of this is that you should use the beta versions of Truffle and the TestRPC. Using beta will sidestep this issue completely. In addition, it should fix most (if not all) installation issues, ever, on every platform. We're likely to release these versions this week.

Sorry for any inconvenience and please let us know if you have any issues with the beta versions. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.