Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename encodeABI in base_contract #3278

Closed
reedsa opened this issue Mar 12, 2024 · 0 comments · Fixed by #3281
Closed

Rename encodeABI in base_contract #3278

reedsa opened this issue Mar 12, 2024 · 0 comments · Fixed by #3281

Comments

@reedsa
Copy link
Contributor

reedsa commented Mar 12, 2024

What was wrong?

Method doesn't follow standard Python conventions, should be encode_abi.

How can it be fixed?

Deprecate in v6.
For v7, rename the class method and update references.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename Contract.encodeABI -> Contract.encode_abi reedsa/web3.py
1 participant
@reedsa