Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vyper decimal10 abi type support #700

Closed
djrtwo opened this issue Mar 16, 2018 · 7 comments
Closed

Vyper decimal10 abi type support #700

djrtwo opened this issue Mar 16, 2018 · 7 comments

Comments

@djrtwo
Copy link
Contributor

djrtwo commented Mar 16, 2018

  • Version: 4.0.0-beta
  • Python: 2.7/3.4/3.5
  • OS: osx/linux/win

What was wrong?

There is currently no support for vyper abi type decimal10. Although vyper is in alpha, it is increasingly used by ethereum research team for casper and sharding.

How can it be fixed?

Add support for decimal10 abi type :)

@djrtwo
Copy link
Contributor Author

djrtwo commented Mar 16, 2018

This is on my to-do list but I'm not sure when I will get to it.
If someone else begins development on it, just let me know here.

@pipermerriam
Copy link
Member

cc @davesque can you get this issue duplicated in the eth-abi repository. I think this is higher priority than the tuple type work that I initially pointed you at.

I think this also suggests prioritizing ethereum/eth-abi#36 ahead of tuple types might also be beneficial so that it's easier for 3rd party encoders/decoders to be written without requiring a core change to the eth-abi library.

@davesque
Copy link
Contributor

@pipermerriam Sure no problem. Sorry I missed this the other day.

@davesque
Copy link
Contributor

eth-abi issue: ethereum/eth-abi#39

@carver
Copy link
Collaborator

carver commented Mar 20, 2018

So almost all of the work will happen in eth-abi#39, but I'll leave this one open until we upgrade eth-abi in web3.

@carver
Copy link
Collaborator

carver commented Apr 19, 2018

I suspect we'll be seeing Vyper switch to fixedMxN based on vyperlang/vyper#566

Continuing to leave this issue open until that's confirmed.

@dylanjw
Copy link
Contributor

dylanjw commented Aug 7, 2018

Vyper included the switch from decimal10 to fixed168x10 in vyperlang/vyper#815

@dylanjw dylanjw closed this as completed Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants