Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3 4.3.0 has requirement websockets<5.0.0,>=4.0.1, but you'll have websockets 5.0.1 which is incompatible. #908

Closed
drandreaskrueger opened this issue Jun 18, 2018 · 6 comments

Comments

@drandreaskrueger
Copy link

drandreaskrueger commented Jun 18, 2018

is there any good way to avoid this version conflict ?

energywebfoundation/ew-link-origin#6 (comment)

at the moment, when not giving any versions, that list of dependencies can just not be installed.

Problematic are resin-sdk 4.7.0 and web3 4.3.0.

Thanks.

  • Version: 4.3.0
  • Python: 3.5
  • OS: linux
@pipermerriam
Copy link
Member

Our standard practice is to pin within major versions. However, we can open up testing to v5 of websockets and see if everything still works as expected.

@drandreaskrueger
Copy link
Author

thx a lot!

@voith
Copy link
Contributor

voith commented Jun 18, 2018

@pipermerriam websockets v5 has some breaking changes which were causing tests to fail. Which is why I pinned the websockets version in #860. But I did not dig in to find the changes that were causing the failures.

@pipermerriam
Copy link
Member

Good to know. Going to open a separate issue for this.

@pipermerriam
Copy link
Member

@drandreaskrueger closing as this doesn't appear to be a bug. You can pin your websockets dependency to <5

@voith
Copy link
Contributor

voith commented Jun 19, 2018

@drandreaskrueger have a look at #912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants