Port to typescript 2

[dryajov]

Continuation of #51

[lgtm-com]

This pull request introduces 1 alert and fixes 1 when merging 41d2bec into 22c9a1c - view on LGTM.com

new alerts:

• 1 for Useless conditional

fixed alerts:

• 1 for Useless conditional

[dryajov]

@holgerd77 @PhilippLgh this seems to be passing now, is there anything else missing?

[holgerd77]

@PhilippLgh We don't need to directly integrate a new Common version here but can you short-term open a PR with an update on the bootnodes? Then it is at least possible to manually take over the bootnodes from there and run and test the examples here from the library.

We can then do a separate PR here integrating a new Common version (and likely also a few others 😄).

[holgerd77]

(or - third version - to speed things up if you are eager to merge: you can also do a local example run and just paste the result here, this just need to get through to block/tx sync in some decent amount of time)

[PhilippLgh]

Just finished the bootnode PR: ethereumjs/ethereumjs-common#83

[PhilippLgh]

tested the examples locally with a linked updated version of ethereumjs-common and it seems to be fine... though I'm not 100% sure what output to expect

npm link "ethereumjs-common"
npm run build
node dist/examples/simple.js
node dist/examples/peer-communication.js

moved examples to src. everything else seems to be extremely complicated if not impossible: microsoft/TypeScript#9858 (comment)

two minor improvements would be to have package.json scripts for examples and remove examples from production build...

[lgtm-com]

This pull request introduces 1 alert and fixes 1 when merging 2a826c7 into 22c9a1c - view on LGTM.com

new alerts:

• 1 for Useless conditional

fixed alerts:

• 1 for Useless conditional

[holgerd77]

@PhilippLgh Thanks! There are still some linting errors in the example files, can you fix?

[holgerd77]

Skimmed a last time through the code changes, from my side this looks good now. @PhilippLgh feel free to merge once you are satisfied with the changes and feel this is ready.

Dmitriy @dryajov Thanks again for all the hard work here, so great! 😀 Beside you also really deserve some Outstanding-Patience-Award here for ever again keeping on with this after such a long period of time.

Thanks! 🙏

[holgerd77]

For a release I would suggest we give this another let's say 2 weeks of time, eventually we can target April 15, Wednesday, or eventually the Tuesday. Philipp wanted to give this some more maintenance work and during this time the dust can settle a bit, eventually Philipp also stumbles upon some more glitches while just using the library and doing updates and active development work.

[holgerd77]

(no totally fix date though, just as some orientation so this won't get lost again)

[PhilippLgh]

would merge this and follow the proposed two weeks game plan

[PhilippLgh]

lgtm