Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: remove isTruthy and isFalsy #2255

Merged
merged 3 commits into from
Aug 30, 2022
Merged

common: remove isTruthy and isFalsy #2255

merged 3 commits into from
Aug 30, 2022

Conversation

gabrocheleau
Copy link
Contributor

Extracts common from #2233

@gabrocheleau gabrocheleau requested review from faustbrian, holgerd77, acolytec3 and jochem-brouwer and removed request for faustbrian August 30, 2022 04:31
@codecov
Copy link

codecov bot commented Aug 30, 2022 •
edited
Loading

Codecov Report

Merging #2255 (ae94c90) into master (2a31b56) will decrease coverage by 2.19%.
The diff coverage is 84.61%.

Impacted file tree graph

Flag Coverage Δ
block 92.77% <ø> (ø)
blockchain ?
client ?
common 98.09% <84.61%> (-0.01%) ⬇️
devp2p 92.33% <ø> (ø)
evm 79.11% <ø> (?)
rlp ∅ <ø> (∅)
statemanager ?
trie 89.43% <ø> (ø)
util 92.33% <ø> (ø)
vm ?

Flags with carried forward coverage won't be shown. Click here to find out more.

jochem-brouwer
jochem-brouwer approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabrocheleau gabrocheleau merged commit 742514a into master Aug 30, 2022
@gabrocheleau gabrocheleau deleted the common/remove-isTruthy-isFalsy branch August 30, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jochem-brouwer jochem-brouwer jochem-brouwer approved these changes

@holgerd77 holgerd77 Awaiting requested review from holgerd77

@faustbrian faustbrian Awaiting requested review from faustbrian

@acolytec3 acolytec3 Awaiting requested review from acolytec3

Assignees
No one assigned
Labels
package: common PR state: needs review type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrocheleau @jochem-brouwer