Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Releases #2361

Merged
merged 13 commits into from Oct 18, 2022
Merged

New Releases #2361

merged 13 commits into from Oct 18, 2022

Conversation

holgerd77
Copy link
Member

@holgerd77 holgerd77 commented Oct 17, 2022

Follow-up on #2270

First round of new releases - mainly bugfix releases - following the final breaking release round from September 6, 2022. Some awaited bug fixes in EVM and Trie package e.g., the EVM switches the event emitter package along. Another noteworthy changes and features, new experimental EthersStateManager and Geth genesis.json import functionality for the Common library.

Additional changes:

Open for review, thanks everyone for the continued work on this. 🙂

This also includes a small Client release.

Note: optimally please push fixes directly on the branch and then re-approve, thanks! 🙏

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #2361 (ac16d71) into master (f8c731c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 91.37% <ø> (ø)
blockchain 90.21% <100.00%> (+<0.01%) ⬆️
client 87.00% <ø> (ø)
common 98.13% <ø> (ø)
devp2p 91.65% <ø> (+0.02%) ⬆️
ethash ∅ <ø> (∅)
evm 79.17% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 89.46% <ø> (ø)
trie 90.36% <ø> (-0.30%) ⬇️
tx 97.80% <100.00%> (+<0.01%) ⬆️
util 88.99% <ø> (ø)
vm 85.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits but looks good!


Along some deeper investigation of build errors related to the usage of the `async-eventemitter` package we finally decided to completely switch to a new async event emitter package for VM/EVM events, see PR [#2303](https://github.com/ethereumjs/ethereumjs-monorepo/pull/2303). The old [async-eventemitter](https://github.com/ahultgren/async-eventemitter) package hasn't been updated for several years and the new [eventemitter2](https://github.com/EventEmitter2/EventEmitter2) package is more modern and maintained as well as substantially more used and therefore a future-proof choice for an async event emitter library to build the VM/EVM event emitting system upon.

The significant parts of the API of both the old and the new libraries are the same and the switch shouldn't cause too much hazzle for people upgrading. In case you nevertheless stumble upon upgrading problems regarding the event emitter package switch please feel free to open an issue, we'll be there to assist you on the upgrade!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The significant parts of the API of both the old and the new libraries are the same and the switch shouldn't cause too much hazzle for people upgrading. In case you nevertheless stumble upon upgrading problems regarding the event emitter package switch please feel free to open an issue, we'll be there to assist you on the upgrade!
The significant parts of the API of both the old and the new libraries are the same and the switch shouldn't cause too much hassle for people upgrading. In case you nevertheless stumble upon upgrading problems regarding the event emitter package switch please feel free to open an issue, we'll be there to assist you on the upgrade!

packages/statemanager/CHANGELOG.md Outdated Show resolved Hide resolved
packages/statemanager/CHANGELOG.md Outdated Show resolved Hide resolved
packages/vm/CHANGELOG.md Outdated Show resolved Hide resolved
packages/evm/CHANGELOG.md Outdated Show resolved Hide resolved
packages/tx/CHANGELOG.md Outdated Show resolved Hide resolved
packages/vm/CHANGELOG.md Outdated Show resolved Hide resolved
@g11tech
Copy link
Contributor

g11tech commented Oct 17, 2022

looks good overall ❤️ 🔥 🚀

holgerd77 and others added 5 commits October 18, 2022 09:27
Co-authored-by: g11tech <gajinder@g11.in>
Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com>
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One Q regarding the changelogs but LGTM in general 👍

const common = Common.fromGethGenesis(genesisJson, { chain: 'customChain', genesisHash })
// If you don't have `genesisHash` while initiating common, you can later configure common (for e.g.
// calculating it afterwards by using the `@ethereumjs/blockchain` package)
common.setForkHashes(genesisHash)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be part of the changelog in common..? Or is this just for extra clarity here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you mean that we have added this method in Common? Or some other context?

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed on discord; common changes are on most/all changelogs to raise awareness. LGTM 😄 👍

@holgerd77 holgerd77 merged commit 2e8b1cf into master Oct 18, 2022
@gitpoap-bot
Copy link

gitpoap-bot bot commented Oct 18, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 EthereumJS Contributor:

GitPOAP: 2022 EthereumJS Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@holgerd77 holgerd77 deleted the new-releases branch October 18, 2022 08:14
@holgerd77
Copy link
Member Author

Finally finally: a GitPOAP, yeah (this seems to be totally random, right??)!! 🥳 😜

@holgerd77
Copy link
Member Author

holgerd77 commented Oct 19, 2022

Just published the following releases on npm:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants