-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Releases #2361
New Releases #2361
Conversation
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small nits but looks good!
|
||
Along some deeper investigation of build errors related to the usage of the `async-eventemitter` package we finally decided to completely switch to a new async event emitter package for VM/EVM events, see PR [#2303](https://github.com/ethereumjs/ethereumjs-monorepo/pull/2303). The old [async-eventemitter](https://github.com/ahultgren/async-eventemitter) package hasn't been updated for several years and the new [eventemitter2](https://github.com/EventEmitter2/EventEmitter2) package is more modern and maintained as well as substantially more used and therefore a future-proof choice for an async event emitter library to build the VM/EVM event emitting system upon. | ||
|
||
The significant parts of the API of both the old and the new libraries are the same and the switch shouldn't cause too much hazzle for people upgrading. In case you nevertheless stumble upon upgrading problems regarding the event emitter package switch please feel free to open an issue, we'll be there to assist you on the upgrade! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The significant parts of the API of both the old and the new libraries are the same and the switch shouldn't cause too much hazzle for people upgrading. In case you nevertheless stumble upon upgrading problems regarding the event emitter package switch please feel free to open an issue, we'll be there to assist you on the upgrade! | |
The significant parts of the API of both the old and the new libraries are the same and the switch shouldn't cause too much hassle for people upgrading. In case you nevertheless stumble upon upgrading problems regarding the event emitter package switch please feel free to open an issue, we'll be there to assist you on the upgrade! |
looks good overall ❤️ 🔥 🚀 |
…y dependencies (Common v3.0.1)
…y dependencies (Tx v4.0.1)
…y dependencies (Trie v5.0.1)
…y dependencies (Block v4.0.1)
…y dependencies (StateManager v1.0.1)
…y dependencies (Devp2p v5.0.1)
…y dependencies (Blockchain v6.0.1)
…y dependencies (EVM v1.1.0)
…y dependencies (VM v6.1.0)
…y dependencies (Client v0.6.4)
Co-authored-by: g11tech <gajinder@g11.in> Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com>
de642d7
to
3415d62
Compare
dd86131
to
ac16d71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One Q regarding the changelogs but LGTM in general 👍
const common = Common.fromGethGenesis(genesisJson, { chain: 'customChain', genesisHash }) | ||
// If you don't have `genesisHash` while initiating common, you can later configure common (for e.g. | ||
// calculating it afterwards by using the `@ethereumjs/blockchain` package) | ||
common.setForkHashes(genesisHash) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not be part of the changelog in common..? Or is this just for extra clarity here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you mean that we have added this method in Common? Or some other context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed on discord; common changes are on most/all changelogs to raise awareness. LGTM 😄 👍
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 EthereumJS Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Finally finally: a GitPOAP, yeah (this seems to be totally random, right??)!! 🥳 😜 |
Just published the following releases on npm: |
Follow-up on #2270
First round of new releases - mainly bugfix releases - following the final breaking release round from September 6, 2022. Some awaited bug fixes in EVM and Trie package e.g., the EVM switches the event emitter package along. Another noteworthy changes and features, new experimental EthersStateManager and Geth genesis.json import functionality for the Common library.
Additional changes:
Open for review, thanks everyone for the continued work on this. 🙂
This also includes a small Client release.
Note: optimally please push fixes directly on the branch and then re-approve, thanks! 🙏