Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate runBlock to typescript #512

Merged
merged 2 commits into from May 21, 2019
Merged

Migrate runBlock to typescript #512

merged 2 commits into from May 21, 2019

Conversation

s1na
Copy link
Contributor

@s1na s1na commented May 20, 2019

Another one bites the dust 馃槃

@lgtm-com
Copy link

lgtm-com bot commented May 20, 2019

This pull request introduces 1 alert when merging 5e0f45e into 41e867e - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Comment posted by LGTM.com

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 95.243% when pulling 5e0f45e on ts/runBlock into 41e867e on v4.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃槃

Looks good, thanks!

@holgerd77
Copy link
Member

@s1na If we target a VM v4 release for next Wednesday (so: in 8 days) do you think this would work out? Is the library in a consistent enough state for this? Would you want to do more changes or is anything immovably outstanding to be done before?

@holgerd77
Copy link
Member

holgerd77 commented May 21, 2019

@s1na @alcuadrado Thought a bit about VM releases yesterday. My idea was that we should now switch a bit the focus and concentrate on v4.x releases in the coming weeks implementing/adding the approved Istanbul features one-by-one, so that this hopefully gets their way into dev tools early on and people can get their hands on that to play around. This could eventually lead to a v5 release wrapping up the final Istanbul state - eventually not necessary though. I would give this whole process roughly a timeframe until August 2018.

Along we continue with refactoring, but now on a more gradual pace, @s1na has actually shifted around A LOT of code. 馃構 I would also assume that there might be input from the community on the new structure once we have this out within an official v4 release.

For a v6 release - roughly in October 2018 - we could then wrap up the API changes and expose them, eventually split up the modules and also eventually have this also as an experimental/partly eWASM release, @s1na not sure what your plans with this are and what can be integrated on a stable basis. Continue to work on eWASM VM early on might also help on getting a clearer picture on the API. Once there are two VMs which have to be integrated/talked to it might become easier/more clear to identify the interface structures.

How does this sound?

@s1na
Copy link
Contributor Author

s1na commented May 21, 2019

If we target a VM v4 release for next Wednesday (so: in 8 days) do you think this would work out?

We should be able to do the beta release by then. As you also pointed out in #479 there are some unclear things with the design, but we can solve them gradually. Documentation around the modified parts is also something I'll need to do.

@s1na has actually shifted around A LOT of code

Yeah, too much. This was a mistake. From now I'll change gears and take a more gradual approach.

The plan sounds good. About ewasm, we'll probably know more in future as the scope of ewasm within ethereum 1.x is not fully clear at the moment.

@s1na s1na merged commit c27019b into v4 May 21, 2019
@s1na s1na deleted the ts/runBlock branch May 21, 2019 14:35
@s1na s1na mentioned this pull request May 21, 2019
23 tasks
@holgerd77
Copy link
Member

@s1na Ok, that sounds like a solid plan. Then let's do a beta release next Wednesday. Then we have some 1-2 more weeks for final refinement and generally finishing things up and at the same time have a solid master basis to early on start with 4.x Istanbul implementations without having to do insane rebases towards the new TypeScript basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants