Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make memory.ts use Buffers instead of Arrays #850

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented Aug 26, 2020

This PR closes #827.

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #850 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

Flag Coverage Δ
#account 92.85% <ø> (ø)
#block 77.81% <ø> (-0.26%) ⬇️
#blockchain 81.33% <ø> (ø)
#common 94.14% <ø> (ø)
#ethash 82.22% <ø> (ø)
#tx 94.02% <ø> (-0.14%) ⬇️
#vm 92.49% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, first was confused that there are SO few code changes necessary, but then I did some manual tests on the console e.g. for the write() logic, wasn't aware that arrays and Buffers behave so similarly. So looks good.

Speed change is not really apparent, might nevertheless be a small improvement not measurable by the benchmarks. Will merge.

@holgerd77 holgerd77 merged commit 7e47bb5 into master Aug 27, 2020
@holgerd77 holgerd77 deleted the memory-as-buffer branch August 27, 2020 07:48
@alcuadrado
Copy link
Member

I love the new benchmarking action and this kind of prs! 😍

As Holger mentioned, the performance change is not clear, but it may be because of the benchmarks being too general. Still, having them will be useful to compare things in the mid-term, at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make memory.ts use Buffers instead of Arrays
3 participants