Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Add tests for inherited FakeTransaction functions #114

Closed
holgerd77 opened this issue Jul 5, 2018 · 0 comments · Fixed by #138
Closed

Add tests for inherited FakeTransaction functions #114

holgerd77 opened this issue Jul 5, 2018 · 0 comments · Fixed by #138
Labels
effort: E1 hours good first issue help wanted PR state: WIP prio: P2 very important type: tests

Comments

@holgerd77
Copy link
Member

Test coverage for FakeTransaction is showing 100%. This is very misleading since all the inherited functionality stays untested from a FakeTransaction context.

There where different bugs introduced with recent updates #108 or #113 which could have been easily caught by expanding the test coverage.

Given the importance and wide usage of the FakeTransaction version these tests should be added on a high-priority.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
effort: E1 hours good first issue help wanted PR state: WIP prio: P2 very important type: tests
Projects
None yet
Milestone
No milestone
2 participants
@holgerd77 @chikeichan