Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

Fix broken tests #239

Closed
wants to merge 5 commits into from
Closed

Fix broken tests #239

wants to merge 5 commits into from

Conversation

roman-vanesyan
Copy link
Contributor

@roman-vanesyan roman-vanesyan commented Feb 16, 2020

This PR fixes all broken tests that are left in update-secp2561-depdency. And is complementary to #228.

@roman-vanesyan
Copy link
Contributor Author

Can someone check tests, they are failing because of ethereumjs-config-lint. However ethereumjs-config-lint was broken for me too and locally I was running test:node instead of test.

@lgtm-com
Copy link

lgtm-com bot commented Feb 16, 2020

This pull request introduces 1 alert when merging 07c90cd into 4d40475 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@ryanio
Copy link
Contributor

ryanio commented Feb 16, 2020

@vanesyan have you tried npm run lint:fix and committing any fixed files?

Edit: yep pulled your branch and that fixed it for me.

I'm getting the below error next, perhaps you can help resolve, I don't have much context on the changed tests in the PR:

> nyc --reporter=lcov mocha 'test/*.spec.ts' -- --require ts-node/register


/Users/ryanghods/dev/ethereumjs-util/node_modules/ts-node/src/index.ts:421
    return new TSError(diagnosticText, diagnosticCodes)
           ^
TSError: ⨯ Unable to compile TypeScript:
src/bytes.ts:73:23 - error TS2769: No overload matches this call.
  The last overload gave the following error.
    Argument of type 'any[] | Uint8Array' is not assignable to parameter of type 'string'.
      Type 'any[]' is not assignable to type 'string'.

73       v = Buffer.from(v)
                         ~

  node_modules/@types/node/globals.d.ts:370:5
    370     from(str: string, encoding?: BufferEncoding): Buffer;
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    The last overload is declared here.

@cgewecke
Copy link
Contributor

@vanesyan Thanks so much for this!

Have taken these changes and added them to #228 in e2a389c, preserving you as the author.

Closing here.

@cgewecke cgewecke closed this Apr 23, 2020
@roman-vanesyan
Copy link
Contributor Author

NP, thanks!

@roman-vanesyan roman-vanesyan deleted the fix-broken-tests-secp2561k-update branch April 23, 2020 06:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants