This repository has been archived by the owner on Jun 17, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 274
Fix broken tests #239
Closed
roman-vanesyan
wants to merge
5
commits into
ethereumjs:update-secp2561-dependency
from
roman-vanesyan:fix-broken-tests-secp2561k-update
Closed
Fix broken tests #239
roman-vanesyan
wants to merge
5
commits into
ethereumjs:update-secp2561-dependency
from
roman-vanesyan:fix-broken-tests-secp2561k-update
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can someone check tests, they are failing because of |
This pull request introduces 1 alert when merging 07c90cd into 4d40475 - view on LGTM.com new alerts:
|
@vanesyan have you tried Edit: yep pulled your branch and that fixed it for me. I'm getting the below error next, perhaps you can help resolve, I don't have much context on the changed tests in the PR:
|
4d40475
to
65a459d
Compare
NP, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all broken tests that are left in
update-secp2561-depdency
. And is complementary to #228.