ethers.js doesn't initiate a transaction and fails immediatelly

[novaknole]

Hi guys.

I am really having a hard time understanding this..

Let's look at this line - https://github.com/aragon/govern/blob/17552b1eecf1c79d2a9799c79ed1d2b6df9dbe76/packages/govern-core/contracts/pipelines/GovernQueue.sol#L178

So, what it does is very simple and the below line does transferFrom on feeToken.

Scenario where it fails.

1. I approve 150 + 18 times 0 on the feeToken for the above contract.
2. I call challenge function and it fails with bad fee pull.

Note: I am 100% sure that feeAmount that getDisputeFees returns is 150 + 18 times 0.

The way it fails is that ethers.js doesn't even open metamask to initiate transaction, it immediatelly returns an error.

Scenario Where it succeeds.

I approve 160 + 18 times 0 and then, it succeeds(transaction appears on metamask) and everything is corrct.

I wonder what really happened for the failing scenario ? this woudln't happen a month ago at all.

@ricmoo @zemse

[novaknole]

all good and fixed.

the problem was with my business logic...