Support numeric separators in BigNumber.from()

[aalmada]

Both Solidity and Javascript support underscore as a numeric separator. It makes it a lot easier to read big numbers.

It would be great if BigNumber.from() also supported these.

const ONE_ETH = BigNumber.from("1_000_000_000_000_000_000");
const POINT_ONE_ETH = BigNumber.from("100_000_000_000_000_000");
const POINT_ZERO_ZERO_THREE_ETH = BigNumber.from("3_000_000_000_000_000");

I think the method only has to ignore the underscores.

[ricmoo]

There aren’t any changes planned for v5 as most of my energy is going into v6. I am focused mainly on major bugs and security for v5.

The easiest way to specify numbers like that in v5 is probably parseUnits("3", 18), for example.