-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ow naming+snmp #127
Add ow naming+snmp #127
Conversation
/* global variables */ | ||
ow_global_t ow_global; | ||
|
||
#ifdef ONEWIRE_NAMING_SUPPORT | ||
ow_name_t ow_names_table[OW_SENSORS_COUNT]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would store the sensor name inside the ow_sensor_t (*ow_sensors) to avoid data duplication of ow_rom_code.
The intention behind the usage of ow_names_table where three points:
But you are right, the n x 64 bit rom codes waste a lot of ram. My sugesstion is to use ow_sensors in every case ONEWIRE_POLLING_SUPPORT/ONEWIRE_NAMING_SUPPORT is involved and to define the members as needed. ow_discover_sensor will update records with matching rom codes and append new sensors. The rom codes of named sensors are not touched by ow_discover_sensor if the sensor is not present. |
Sounds good to me. |
I've tried to fix the issues. Your commit is included. |
That was fast :). Looks good! Have you tested the code in combination with ONEWIRE_BUSCOUNT > 1 ? |
I can test it on weekend. I've planed to split my bus anyway :-) |
…ixed loop in ow_periodic
OK. I did the tests even with two buses and I hope I've tested all cominations. I've done the following changes (nothing related to ONEWIRE_BUSCOUNT):
|
Please document your changes in the wiki aswell. http://ethersex.de/index.php/Onewire |
On 10.04.2012 19:32, Maximilian Güntner wrote:
die konfiguration der busse ist ja bereits im o.g. link beschrieben, der grüße |
fix of bug ethersex#127. Implemented a simple parser for PING commands.
fix of bug ethersex#127. Implemented a simple parser for PING commands.
Added support for name mapping of onewire rom addresses to meaningful names. Mappings are stored in EEPROM.
Values and names are queryable by snmp.
Option for reading out values via "1w list"