fix of bug #127. Implemented a simple parser for PING commands. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eku
pushed a commit
that referenced
this pull request
May 28, 2011
fix of bug #127. Implemented a simple parser for PING commands.
eku
pushed a commit
that referenced
this pull request
May 28, 2011
fix of bug #127. Implemented a simple parser for PING commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ethersex erkennt nun PING Commands zwischen anderen Messages. Die aktuelle Revision überprüft nur ob am Beginn "PING :" steht. Bei Quakenet z.B. jedoch kommt sowas rein:
D: irc: ignoring auth fluff ...D: irc: received data: NOTICE AUTH :* Checking Ident
PING :4088118709
NOTICE AUTH :* Found your hostname
NOTICE AUTH :*** No ident response
da am Anfang NOTICE AUTH steht wird dieses Paket im Moment verworfen obwohl das für die Anmeldung wichtige PING darin enthalten ist.
Please pull and close the bug report ;)
Reference: http://bugs.ethersex.de/view.php?id=127