Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: isEthAddress to isHexEthAddress #234

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

AuHau
Copy link
Contributor

@AuHau AuHau commented Mar 29, 2021

No description provided.

@AuHau AuHau added the kind:refactor Refactoring issue label Mar 29, 2021
@AuHau AuHau requested a review from a team March 29, 2021 07:12
Copy link
Contributor

@vojtechsimetka vojtechsimetka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is breaking change though as we expose the function, right? So please add ! and merge as:
refactor!: isEthAddress to isHexEthAddress

@AuHau AuHau force-pushed the refactor/hex-string-improvements branch from 2816955 to bc9875f Compare March 29, 2021 09:04
@AuHau
Copy link
Contributor Author

AuHau commented Mar 29, 2021

Good point thanks!

@AuHau AuHau changed the title refactor: isEthAddress to isHexEthAddress refactor!: isEthAddress to isHexEthAddress Mar 29, 2021
@AuHau AuHau merged commit cfe49e6 into master Mar 29, 2021
@AuHau AuHau deleted the refactor/hex-string-improvements branch March 29, 2021 09:22
@bee-worker bee-worker mentioned this pull request Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants