This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
api, chunk, storage: anonymous uploads #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zelig
approved these changes
Sep 30, 2019
janos
reviewed
Sep 30, 2019
api/http/middleware.go
Outdated
| @@ -131,8 +132,8 @@ func InitUploadTag(h http.Handler, tags *chunk.Tags) http.Handler { | |||
| } | |||
|
|
|||
| log.Trace("creating tag", "tagName", tagName, "estimatedTotal", estimatedTotal) | |||
|
|
|||
| t, err := tags.Create(tagName, estimatedTotal) | |||
| anon := anonTag == "true" | |||
There was a problem hiding this comment.
Maybe to make it case insensitive?
| case chunk.ModeSetSyncPull: | ||
| if tag.Anonymous { | ||
| // this will not get called twice because we remove the item in L217 | ||
| tag.Inc(chunk.StateSent) |
There was a problem hiding this comment.
I would improve this function to increment tag counters only if the batch is successfully written, probably returning bool variables that would be handled in set method.
This can be left for later when tags are persisted. Without persistence, I do not think that it matters.
acud
force-pushed
the
anonymous-tags
branch
from
8165eb8
to
c080aca
Compare
zelig
approved these changes
Oct 1, 2019
Working on it
Well:
Once the code works - gladly |
This is beyond me @acud . Would you walk me through this? |
janos
reviewed
Oct 2, 2019
janos
reviewed
Oct 2, 2019
acud
force-pushed
the
anonymous-tags
branch
3 times, most recently
from
d11164f
to
e04f33e
Compare
janos
suggested changes
Oct 7, 2019
…f ModeSetSyncPull and ModeSetSyncPush
…g values as per pr review
|
The linter is still complaining https://travis-ci.org/ethersphere/swarm/jobs/594965019#L490. |
janos
approved these changes
Oct 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.