This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
pushsync, storage/localstore: set tags synced state in localstore #1821
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge.
This is one example solution for tags to get along with both push and pull syncing. Tag synced state cannot reach total number of chunks as pull syncing is removing chunks from push index on ModeSetSync.
It is debatable if it is correct approach as push and pull syncing have different definition of chunk being synced. But it is the most simple thing to do now.