Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support for NodeJS v20 LTS #209

Open
saicharanmadina opened this issue Jun 18, 2024 · 5 comments
Open

[FEATURE] Add support for NodeJS v20 LTS #209

saicharanmadina opened this issue Jun 18, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@saicharanmadina
Copy link

saicharanmadina commented Jun 18, 2024

Is your feature request related to a problem? Please describe.
Unable to start the bundler using NodeJS v19 and above as the flag experimental-specifier-resolution was deprecated after NodeJS v18
Reference: nodejs/node#44859

Describe the solution you'd like
Please include the solution to support the new NodeJS LTS release

@saicharanmadina saicharanmadina added the enhancement New feature or request label Jun 18, 2024
@arddluma
Copy link
Member

hey @saicharanmadina ,
Thanks for submitting detailed feature request, we will take a look at this and respond!

@ch4r10t33r
Copy link
Member

ch4r10t33r commented Jun 18, 2024

Is your feature request related to a problem? Please describe. Unable to start the bundler using NodeJS v19 and above as the flag experimental-specifier-resolution was deprecated after NodeJS v18 Reference: nodejs/node#44859

Describe the solution you'd like Please include the solution to support the new NodeJS LTS release

Hey @saicharanmadina - Thanks for submitting the request. Can I request you to modify this line in your local version and try running the app?

node --experimental-specifier-resolution=node ./packages/cli/bin/skandha.js "$@"

Does it then work without problems?

@saicharanmadina
Copy link
Author

@ch4r10t33r I need clarification on how to modify the command for my specific Node.js version.
Facing same issue even after running the command without the experimental flag

@ch4r10t33r
Copy link
Member

Can you pls post a screenshot of the error?

@saicharanmadina
Copy link
Author

Can you pls post a screenshot of the error?

node:internal/modules/esm/resolve:259
    throw new ERR_UNSUPPORTED_DIR_IMPORT(path, fileURLToPath(base), String(resolved));
          ^

Error [ERR_UNSUPPORTED_DIR_IMPORT]: Directory import '/workspace/skandha/packages/cli/lib/util' is not supported resolving ES modules imported from /workspace/skandha/packages/cli/lib/index.js
    at finalizeResolution (node:internal/modules/esm/resolve:259:11)
    at moduleResolve (node:internal/modules/esm/resolve:933:10)
    at defaultResolve (node:internal/modules/esm/resolve:1157:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:390:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:359:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:234:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:87:39)
    at link (node:internal/modules/esm/module_job:86:36) {
  code: 'ERR_UNSUPPORTED_DIR_IMPORT',
  url: 'file:///workspace/skandha/packages/cli/lib/util'
}

Node.js v20.12.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants