split and match most functions at f8f60 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know how this happened.
ethteck
reviewed
Aug 15, 2020
pixel-stuck
reviewed
Aug 15, 2020
Closed
bates64
commented
Aug 15, 2020
| s32 rand_int(s32); | ||
| void sort_items(void); | ||
| s32 is_ability_active(s32 arg0); | ||
| f32 update_lerp(EASING easing, f32 start, f32 end, s32 elapsed, s32 duration); | ||
|
|
||
| npc* get_npc_safe(NPC npcID); | ||
| npc* get_npc_unsafe(NPC npcID); | ||
| npc* resolve_npc(script_context* script, NPC npcID); |
There was a problem hiding this comment.
It might be worth declaring some kind of union for resolve_npc's second arg - e.g. union { npc* ptr; NPC special; u8 id }. AFAIK the get_npc don't check for NPC special and should just take a u8 id. We might even want to rename them - and suggest the same to Clover - to get_npc_by_id.
There was a problem hiding this comment.
Update: changing the get_npc_ signatures to take a u8 rather than an s32 doesn't match.
…02D0C94, SetMessageString. WIP SetMessageValue (issue with extra NOP)
…ntPrintContext and D_802DB268 (related)
… in places where it's not stricly necessary, but good practice.
ethteck
reviewed
Aug 16, 2020
ethteck
reviewed
Aug 16, 2020
z64a
pushed a commit
to z64a/papermario
that referenced
this pull request
Mar 9, 2023
Added symbols and restructured game_status a little bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split and matched all functions in this file, other than:
setup_path_data, for example, is huge!func_802D4BDC,func_802D4C4C- has a redundant branch instruction that probably skipped a debug printf at one point. I don't know how to replicate this - the compiler optimises away the empty if block.func_802D4CC4- loads an f32 from0xBF800000- which is a reference to some DMA'd ROM data, I think.