wip: Add native cmake build support #15
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,63 @@ | ||
| cmake_minimum_required(VERSION 2.8.3) | ||
| project(ifopt) | ||
| option(CATKIN_BUILD "CATKIN_BUILD" ON) | ||
| MESSAGE(STATUS "CATKIN_BUILD is " ${CATKIN_BUILD}) | ||
|
|
||
| if(${CATKIN_BUILD}) | ||
| find_package(catkin REQUIRED) | ||
|
There was a problem hiding this comment. This actually returns a variable CATKIN_FOUND that could be used instead of the CATKIN_BUILD, that way this flag does not have to be set by the user. |
||
| catkin_metapackage() | ||
| else() | ||
| # do native cmake build | ||
| # add gtest and gmock support | ||
| # - see http://www.kaizou.org/2014/11/gtest-cmake/ | ||
| # ------------- BEGIN FROM BLOG ------------------ | ||
|
There was a problem hiding this comment. This whole section for unit testing with gtest seems a bit long, as well as there exist some native cmake functions that should handle that (https://cmake.org/cmake/help/v2.8.3/cmake.html#module:FindGTest). I would prefer to do something like they did here (create and download manually, cmake only checks if folder exists,...): |
||
| # We need thread support | ||
| find_package(Threads REQUIRED) | ||
|
|
||
| # Enable ExternalProject CMake module | ||
| include(ExternalProject) | ||
|
|
||
| # Download and install GoogleTest | ||
| ExternalProject_Add( | ||
| gtest | ||
| URL https://github.com/google/googletest/archive/master.zip | ||
| PREFIX ${CMAKE_CURRENT_BINARY_DIR}/gtest | ||
| # Disable install step | ||
| INSTALL_COMMAND "" | ||
| ) | ||
|
|
||
| # Get GTest source and binary directories from CMake project | ||
| ExternalProject_Get_Property(gtest source_dir binary_dir) | ||
|
|
||
| # Create a libgtest target to be used as a dependency by test programs | ||
| add_library(libgtest IMPORTED STATIC GLOBAL) | ||
| add_dependencies(libgtest gtest) | ||
|
|
||
| # Set libgtest properties | ||
| set_target_properties(libgtest PROPERTIES | ||
| "IMPORTED_LOCATION" "${binary_dir}/googlemock/gtest/libgtest.a" | ||
| "IMPORTED_LINK_INTERFACE_LIBRARIES" "${CMAKE_THREAD_LIBS_INIT}" | ||
| ) | ||
|
|
||
| # Create a libgmock target to be used as a dependency by test programs | ||
| add_library(libgmock IMPORTED STATIC GLOBAL) | ||
| add_dependencies(libgmock gtest) | ||
|
|
||
| # Set libgmock properties | ||
| set_target_properties(libgmock PROPERTIES | ||
| "IMPORTED_LOCATION" "${binary_dir}/googlemock/libgmock.a" | ||
| "IMPORTED_LINK_INTERFACE_LIBRARIES" "${CMAKE_THREAD_LIBS_INIT}" | ||
| ) | ||
|
|
||
| # I couldn't make it work with INTERFACE_INCLUDE_DIRECTORIES | ||
| include_directories("${source_dir}/googletest/include" | ||
| "${source_dir}/googlemock/include") | ||
| # ------------- END FROM BLOG ------------------ | ||
|
|
||
| enable_testing() | ||
|
|
||
| # add subdirectories | ||
| add_subdirectory("../ifopt_core" "../../ifopt_core/build") | ||
|
There was a problem hiding this comment. I'm not sure if we want to add the base and the "/build" repos here. |
||
| add_subdirectory("../ifopt_ipopt" "../../ifopt_ipopt/build") | ||
| add_subdirectory("../ifopt_snopt" "../../ifopt_snopt/build") | ||
| endif() | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best case this is just
cmake ..and the system automatically detects that it should build without catkin and where the files should be installed. Possibly its even better to avoid system-wide installation and just keep all files local in thebuildfolder.