Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small bug in HeightMap::GetDerivativeOfNormalizedBasisWrt() #96

Open
caoweiquan322 opened this issue Apr 12, 2022 · 0 comments
Open

Comments

@caoweiquan322
Copy link

Hello,

I believe I found a bug in HeightMap::GetDerivativeOfNormalizedBasisWrt().

The code below

Vector3d dn_norm_wrt_n = GetDerivativeOfNormalizedVectorWrtNonNormalizedIndex(v, dim);
return dn_norm_wrt_n.cwiseProduct(dv_wrt_dim);

should be replaced by

  Eigen::Matrix3d dn_norm_wrt_n;
  dn_norm_wrt_n << GetDerivativeOfNormalizedVectorWrtNonNormalizedIndex(v, 0),
                   GetDerivativeOfNormalizedVectorWrtNonNormalizedIndex(v, 1),
                   GetDerivativeOfNormalizedVectorWrtNonNormalizedIndex(v, 2);
  return dn_norm_wrt_n * dv_wrt_dim;

Am I correct? Please confirm. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant