Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first prototype for detecting invalid features #174

Merged
merged 1 commit into from
Nov 21, 2021

Conversation

pascalau
Copy link
Collaborator

The function check features checks if the X matrix contains columns that are filled with only zeros. And raises a warning for the user that this coefficient will probably be wrong.

Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! I think this is probably good enough for now, and we can do a more elegant solution as we learn more

Copy link
Contributor

@manumerous manumerous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! That is a great addition to the pipeline! :)

@manumerous manumerous merged commit 29775ea into master Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants