Safeguard for actuator normalization and fixing stall angle conversion #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A safeguard ensuring that the actuator normalization never produces negative values was added. This was needed since for example vertical rotors of the standart vtol quadplane have actuator values of 900 in fixed wing mode, even though their minimal pwm is specified as 1000. Secondly the stall angle was currently specified in degrees without converting it to radians. This conversion is needed to use it together with the angle of attack and the trigonometric functions of the math library. The default stall angle was increased to 35 degrees for now.
I decided to move the each model to it's own folder inside models. This way we can store all test logs, tests and performance results of this model inside its corresponding directory.
Jaeyoung-Lim
requested changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A safeguard ensuring that the actuator normalization never produces negative values was added. This was needed since for example vertical rotors of the standart vtol quadplane have actuator values of 900 in fixed wing mode, even though their minimal pwm is specified as 1000.
Secondly the stall angle was currently specified in degrees without converting it to radians. This conversion is needed to use it together with the angle of attack and the trigonometric functions of the math library. The default stall angle was increased to 35 degrees for now.