-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sensor configuration and Noise levels #90
Comments
@flaviofontana sorry for the delay on this. I agree with your suggestion and I would be happy see these fixed in the framework. The unit of the measurement noise on the orientation is expressed in radians. |
I'm glad to see your improvement. I was struggling with this "unit problem". |
@simonlynen Thanks for your reply I started working on integrating the comments, I also took the liberty to modify the pose_sensor config file and add comments. Let me know if this approach is ok for you I still have two open questions
cheers, |
@flaviofontana yes, the changelist looks great! qs:
|
@simonlynen Thanks again for your answers.
I will finish it tmrw and send then a pull request. flavio |
@flaviofontana yes, the additional inflation of the covariance for the scale estimate can be used to model larger drifts in the scale of the SLAM system. The scale is estimated independently from that. I would prefer if you left it at zero like the covariance inflation on the extrinsic calibration. |
@flaviofontana Please take a look at this definitions here and try to either point to these or adopt as much of the notation as possible: https://github.com/ethz-asl/kalibr/wiki/IMU-Noise-Model-and-Intrinsics |
Reading through the issue list I see a lot of questions 1, 2, 3, regarding how to set the sensor configuration correctly.
There seems to be a lot of confusion in what units these values are. I will write down some terms and units that we talk about the same.
I think that the configuration throughout the framework is not consistent yet and that me need to adapt some comments.
in the Core cfg the comment is std/dev however I suspect what you enter here is treated as a NSD. I can trace it until the calcQCore.h but then I can not understand what happens with it any more. But according to multiple comments by the authors this is a continuous noise spectral density.
Then for the pose sensor cfg the comment is again std dev. And I think here it is ok. Looking at the code.
If we provide a pose with covariance the provided covariance is used directly. If fixed_covariance_ is set we take the std dev from the config and square it to get the covariances.
To sum it up can we please write down the units for the config file. My suggestion is the following
Once the problem is discussed we are happy to help fixing the comments in the cfg file.
Gruss Flavio and Antonio
The text was updated successfully, but these errors were encountered: