Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incrementally loading terrain from VRT server #63

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Jaeyoung-Lim
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim commented Apr 13, 2024

Problem Description
This PR adds a terrain loading node to load a terrain from a VRT server, instead of loading from a tif file.

terrain-loader

Note

  • Doing cell-wise reprojection is quite expensive (depending on the resolution)
  • Currently missing the capability of publishing multiple DEMs at once

@Jaeyoung-Lim Jaeyoung-Lim removed the request for review from Ryanf55 April 13, 2024 16:40
@Jaeyoung-Lim Jaeyoung-Lim marked this pull request as draft April 13, 2024 16:41
@Jaeyoung-Lim Jaeyoung-Lim changed the title [DONOTMERGE] VRT test ros1 Incrementally loading terrain from VRT server Apr 13, 2024
@Jaeyoung-Lim Jaeyoung-Lim force-pushed the pr-vrt-ros1 branch 3 times, most recently from 20c7a7f to 0ebc1d9 Compare April 13, 2024 16:48
@Jaeyoung-Lim Jaeyoung-Lim force-pushed the pr-vrt-ros1 branch 2 times, most recently from 2e4fb1c to 83b8292 Compare April 14, 2024 18:23
Use gdal transforms

Remove geoconversion library

F

F
auto cell_position_lv03 = cell_position + query_position_lv03.head(2); // Position of cell in CH1903/LV03
double dummy;
Eigen::Vector2d cell_position_wgs84;
transformCoordinates(ESPG_CH1903_LV03, cell_position_lv03(0), cell_position_lv03(1), cell_position_lv03(2),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than transform individual coordinates, do you think doing a warp operation in gdal would lead to higher performance?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ryanf55 Definitely, but not sure how we can do this within the cpp API. Do you have any ideas on how to do it with a vrt? Or should we do it after copying over?

Copy link
Collaborator

@Ryanf55 Ryanf55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants