Transformation.cpp: There is no chain, the transform must be applied once #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| if (num_iter != 1) | ||
| throw "Transformations: Error, the transform should have been applied just once."; |
There was a problem hiding this comment.
This is going to throw an instance of const char *.
I would suggest throwing something more usual, such as std::runtime_error. Otherwise it is very unlikely that this text will be visible in case of this exception. Most likely the user is going to see something like
terminate called after throwing an instance of 'char const*'
Aborted
instead.
There was a problem hiding this comment.
I did not give this much thought honestly. Here's a new pull request with the exception type you suggest. #166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.