Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3d => 2d conversion function #114

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

shagren
Copy link
Contributor

@shagren shagren commented Apr 7, 2021

No description provided.

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #114 (2b31c8e) into master (146a250) will decrease coverage by 1.59%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   91.55%   89.96%   -1.60%     
==========================================
  Files           5        9       +4     
  Lines         308      578     +270     
==========================================
+ Hits          282      520     +238     
- Misses         26       58      +32     
Impacted Files Coverage Δ
pyk4a/calibration.py 88.05% <90.00%> (ø)
pyk4a/capture.py 73.49% <0.00%> (ø)
pyk4a/playback.py 98.21% <0.00%> (ø)
pyk4a/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 146a250...2b31c8e. Read the comment docs.

@lpasselin
Copy link
Collaborator

Wow awesome, thanks a lot for taking the time to add this.
#100
Let me know when you want to merge. It looks good to me already.

@shagren
Copy link
Contributor Author

shagren commented Apr 7, 2021

@lpasselin , yeah. PR ready for merge

@lpasselin lpasselin merged commit 74d72ea into etiennedub:master Apr 7, 2021
lpasselin added a commit that referenced this pull request Apr 7, 2021
@lpasselin lpasselin mentioned this pull request Apr 7, 2021
lpasselin added a commit that referenced this pull request Apr 8, 2021
- Use clang-format as CPP code formatter/linter (#105)
- Available devices count (#107)
- Recording support (#106)
- Capture color exposure and white balance properties (#110)
- Calibration: Add functions to access intrinsics (#113)
- Add 3d => 2d conversion function (#114)

* Run test with different python versions (#65)

* Add matrix to workflow

* Change python versions list

* Change python versions list

* Add k4a versions to matrix

* Typofix

* Drop k4a from matrix

* Add dataclasses requirement for python <3.7

* Fix python 3.6 test behavior

* Fix python 3.6 test behavior

* Restore fail-fast option

* fix conversion seconds to ns

* fix conversion seconds to ns

* fix timestamp ns to us

Co-authored-by: Louis-Philippe Asselin <louisphilippeasselin@gmail.com>

* fix install using pip --editable --user (#67)

* Codecov support (#64)

* Codecov support

* Add badge

* Order badges

* fix capture.transformed_depth_point_cloud (#73)

* version 1.0.1

* Added transformed_ir with transform_depth_image_to_color_camera_custom functionality (#76)

* Added transform_depth_image_to_color_camera_custom functionality

* keeping things c

* add interpolation option condition as a parameter

* returned the depth image

* unpack return value if not None so avoid error

* Image timestamp support (#88)

* Support for capture images timestamps

* Support for capture images timestamps

* Add more changes

* version 1.1.0

* fix lint

* readme fix wrong example version of SDK

* Use clang-format as CPP code formatter/linter (#105)

* Use clang-format as CPP code formatter/linter

* Add missed .clang-format

* Available devices count (#107)

* Add ability to querying devices count and read serial numbers

* Fix test

* Rename installed_count => connected_device_count

* Recording support (#106)

* Recording support

* Tests

* Small refactoring

* Add ability to querying devices count and read serial numbers

* Fix test

* Fix format

* Capture color exposure and white balance properties (#110)

* Add color_white_balance and exposure_usec properties to capture

* Add color_white_balance and exposure_usec properties to capture

Co-authored-by: Louis-Philippe Asselin <lpasselin@users.noreply.github.com>

* Calibration: Add functions to access intrinsics (#113)

Camera matrix and distortion coefficients in OpenCV-compatible format.
These values are already specific to the selected camera resolution (in contrast to those accessed through calibration_raw).

related to #35, #69

Co-authored-by: Johan von Forstner <johan.vonforstner@paradoxcat.com>

* version 1.2.0

Co-authored-by: Ilya Gruzinov <igruzinov@yandex.ru>
Co-authored-by: Samuel Boulanger <samuelrdboulanger@gmail.com>
Co-authored-by: Johan von Forstner <johan.forstner@gmail.com>
Co-authored-by: Johan von Forstner <johan.vonforstner@paradoxcat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants