Added transform_depth_image_to_color_camera_custom functionality #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #76 +/- ##
===========================================
- Coverage 91.83% 91.55% -0.28%
===========================================
Files 5 5
Lines 306 308 +2
===========================================
+ Hits 281 282 +1
- Misses 25 26 +1
Continue to review full report at Codecov.
|
|
Hope the codecov failures aren't an issue. Don't really know what that is about. |
lpasselin
reviewed
Nov 3, 2020
lpasselin
requested changes
Nov 3, 2020
|
Thank you for the PR. I added some small comments. Good work I'm sure we'll merge this soon!
Yeah we'll have to add a test to merge. It will propably be similar to the depth transformation tests. |
|
I saw your comments and made some changes. Check them out.
No thank YOU for creating this great project. |
|
Can you test that the transformed_depth is good? Something like the following If it works, I'll merge even if we don't have tests. An (unecessary for now) optimization would be to skip generation of the np_depth if we already have a capture.transformed_depth. |
|
All is good! I did some tests and they all passed. Yes some optimization could definitely be done. For now, the best practice is to just call for transformed_ir before transformed_depth so the depth transformation is not done twice. |
lpasselin
added a commit
that referenced
this pull request
Dec 15, 2020
* Run test with different python versions (#65) * Add matrix to workflow * Change python versions list * Change python versions list * Add k4a versions to matrix * Typofix * Drop k4a from matrix * Add dataclasses requirement for python <3.7 * Fix python 3.6 test behavior * Fix python 3.6 test behavior * Restore fail-fast option * fix conversion seconds to ns * fix conversion seconds to ns * fix timestamp ns to us Co-authored-by: Louis-Philippe Asselin <louisphilippeasselin@gmail.com> * fix install using pip --editable --user (#67) * Codecov support (#64) * Codecov support * Add badge * Order badges * fix capture.transformed_depth_point_cloud (#73) * version 1.0.1 * Added transformed_ir with transform_depth_image_to_color_camera_custom functionality (#76) * Added transform_depth_image_to_color_camera_custom functionality * keeping things c * add interpolation option condition as a parameter * returned the depth image * unpack return value if not None so avoid error * Image timestamp support (#88) * Support for capture images timestamps * Support for capture images timestamps * Add more changes * version 1.1.0 * fix lint * readme fix wrong example version of SDK Co-authored-by: Ilya Gruzinov <igruzinov@yandex.ru> Co-authored-by: Samuel Boulanger <samuelrdboulanger@gmail.com>
lpasselin
added a commit
that referenced
this pull request
Apr 8, 2021
- Use clang-format as CPP code formatter/linter (#105) - Available devices count (#107) - Recording support (#106) - Capture color exposure and white balance properties (#110) - Calibration: Add functions to access intrinsics (#113) - Add 3d => 2d conversion function (#114) * Run test with different python versions (#65) * Add matrix to workflow * Change python versions list * Change python versions list * Add k4a versions to matrix * Typofix * Drop k4a from matrix * Add dataclasses requirement for python <3.7 * Fix python 3.6 test behavior * Fix python 3.6 test behavior * Restore fail-fast option * fix conversion seconds to ns * fix conversion seconds to ns * fix timestamp ns to us Co-authored-by: Louis-Philippe Asselin <louisphilippeasselin@gmail.com> * fix install using pip --editable --user (#67) * Codecov support (#64) * Codecov support * Add badge * Order badges * fix capture.transformed_depth_point_cloud (#73) * version 1.0.1 * Added transformed_ir with transform_depth_image_to_color_camera_custom functionality (#76) * Added transform_depth_image_to_color_camera_custom functionality * keeping things c * add interpolation option condition as a parameter * returned the depth image * unpack return value if not None so avoid error * Image timestamp support (#88) * Support for capture images timestamps * Support for capture images timestamps * Add more changes * version 1.1.0 * fix lint * readme fix wrong example version of SDK * Use clang-format as CPP code formatter/linter (#105) * Use clang-format as CPP code formatter/linter * Add missed .clang-format * Available devices count (#107) * Add ability to querying devices count and read serial numbers * Fix test * Rename installed_count => connected_device_count * Recording support (#106) * Recording support * Tests * Small refactoring * Add ability to querying devices count and read serial numbers * Fix test * Fix format * Capture color exposure and white balance properties (#110) * Add color_white_balance and exposure_usec properties to capture * Add color_white_balance and exposure_usec properties to capture Co-authored-by: Louis-Philippe Asselin <lpasselin@users.noreply.github.com> * Calibration: Add functions to access intrinsics (#113) Camera matrix and distortion coefficients in OpenCV-compatible format. These values are already specific to the selected camera resolution (in contrast to those accessed through calibration_raw). related to #35, #69 Co-authored-by: Johan von Forstner <johan.vonforstner@paradoxcat.com> * version 1.2.0 Co-authored-by: Ilya Gruzinov <igruzinov@yandex.ru> Co-authored-by: Samuel Boulanger <samuelrdboulanger@gmail.com> Co-authored-by: Johan von Forstner <johan.forstner@gmail.com> Co-authored-by: Johan von Forstner <johan.vonforstner@paradoxcat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to transform IR images to color camera format using the k4a_depth_image_to_color_camera_custom function. There is still work to be done because I am pretty sure the depth image is being transformed as well. So it is redundant to only do this with the ir image. Although I am not sure the best way to return both depth and ir images from the c++ function. TODO in the future.