Recording support #106
Merged
Recording support #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #106 +/- ##
==========================================
Coverage ? 90.57%
==========================================
Files ? 10
Lines ? 647
Branches ? 0
==========================================
Hits ? 586
Misses ? 61
Partials ? 0 Continue to review full report at Codecov.
|
|
@lpasselin , can you check my PR |
|
I took a quick look and it seems clean and simple enough! |
|
Will be OK both options. |
Merged
lpasselin
added a commit
that referenced
this pull request
Apr 8, 2021
- Use clang-format as CPP code formatter/linter (#105) - Available devices count (#107) - Recording support (#106) - Capture color exposure and white balance properties (#110) - Calibration: Add functions to access intrinsics (#113) - Add 3d => 2d conversion function (#114) * Run test with different python versions (#65) * Add matrix to workflow * Change python versions list * Change python versions list * Add k4a versions to matrix * Typofix * Drop k4a from matrix * Add dataclasses requirement for python <3.7 * Fix python 3.6 test behavior * Fix python 3.6 test behavior * Restore fail-fast option * fix conversion seconds to ns * fix conversion seconds to ns * fix timestamp ns to us Co-authored-by: Louis-Philippe Asselin <louisphilippeasselin@gmail.com> * fix install using pip --editable --user (#67) * Codecov support (#64) * Codecov support * Add badge * Order badges * fix capture.transformed_depth_point_cloud (#73) * version 1.0.1 * Added transformed_ir with transform_depth_image_to_color_camera_custom functionality (#76) * Added transform_depth_image_to_color_camera_custom functionality * keeping things c * add interpolation option condition as a parameter * returned the depth image * unpack return value if not None so avoid error * Image timestamp support (#88) * Support for capture images timestamps * Support for capture images timestamps * Add more changes * version 1.1.0 * fix lint * readme fix wrong example version of SDK * Use clang-format as CPP code formatter/linter (#105) * Use clang-format as CPP code formatter/linter * Add missed .clang-format * Available devices count (#107) * Add ability to querying devices count and read serial numbers * Fix test * Rename installed_count => connected_device_count * Recording support (#106) * Recording support * Tests * Small refactoring * Add ability to querying devices count and read serial numbers * Fix test * Fix format * Capture color exposure and white balance properties (#110) * Add color_white_balance and exposure_usec properties to capture * Add color_white_balance and exposure_usec properties to capture Co-authored-by: Louis-Philippe Asselin <lpasselin@users.noreply.github.com> * Calibration: Add functions to access intrinsics (#113) Camera matrix and distortion coefficients in OpenCV-compatible format. These values are already specific to the selected camera resolution (in contrast to those accessed through calibration_raw). related to #35, #69 Co-authored-by: Johan von Forstner <johan.vonforstner@paradoxcat.com> * version 1.2.0 Co-authored-by: Ilya Gruzinov <igruzinov@yandex.ru> Co-authored-by: Samuel Boulanger <samuelrdboulanger@gmail.com> Co-authored-by: Johan von Forstner <johan.forstner@gmail.com> Co-authored-by: Johan von Forstner <johan.vonforstner@paradoxcat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recording feature with minimal functionality - only camera captures will be stored in mkv file.
IMU not supported.
If you pass opened and started device then Meta information like calibration, firmvare versions, ... etc will be written too.