Find cjson on Fedora, where cmake config is missing #2289
Conversation
|
A drawback of this change is it prefers pkg-config information over cJSON cmake module, even when it is present. I am not sure how that could be avoided and FindcJSON would use it only when normal config is missing. |
|
Wonder if this custom findcjson actually breaks the build on some distros (arch for instance). It would be nice to get some feedback from users of other distros on this. Also, just static linking the cjson from the bundled libs is not such a big deal as it is just a single file… |
If BUNDLED_LIBS is disabled and cjson library does not ship its cmake config for some reason, attempt to find it the other way. That is the case on current Fedora cjson package. Provide CJSON_LIBRARY in addition to CJSON_LIBRARIES variable.
Use just CJSON_LIBRARIES similar to other modules.
Use config by default even when FindcJSON module is preferred. Try CONFIG only and if that works, not not attempt other methods. Should behave exactly the same way as if FindcJSON module were not present.
|
Number of files does not really matter. Fedora guidelines are very clear about this and cjson has its own package. I do not see a good reason for bundling it. But I have found a way to have it maximally compatible and prefer CONFIG mode, if it works. It can still use pkg-config or plain library search |
|
@pemensik is this only impacting F38? |
|
It affects Fedora 38 and older. cjson-devel on Fedora 39 already contains cmake module, starting with version 1.7.15. It can of course affect also other distributions, but Debian had it present also on previous oldstable. I have made no extensive search across distributions how they are built. If they are built with cmake, cmake module is made. Depends what package maintainer has chosen. |
|
@jackeri It is not because the size of additional code. But using static library requires all dependent packages rebuilt if serious bug or even security vulnerability were found. With shared library just the library is rebuilt and unless it modifies ABI, that's it. I think that is primary reason why Fedora requires all libraries in shared form if possible. |
|
Of course EPEL builds are affected as well. Not sure if anyone is compiling etlegacy on RHEL or their clones. |
|
Not sure what the status of this is and if this is still being considered or what, but FWIW it doesn't seem to break anything on Arch. |
Current fedora packages do not ship cmake config on cjson-devel package in any release. That should get fixed, but allow locating of cjson via pkg-config in that case.