UI accelerators #2587
Closed
UI accelerators #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aciz
reviewed
Jun 1, 2024
Vorschreibung
force-pushed
the
ui-accelerators
branch
from
1de187a
to
4428b72
Compare
|
Really like this idea, though it does break the automatic generation of the translation files (which we haven't really used in a long time), but if that is all we can probably live with it. |
Aranud
requested changes
Jun 7, 2024
Vorschreibung
force-pushed
the
ui-accelerators
branch
from
4428b72
to
67fb1c2
Compare
Via `^_` meta characters in Texts.
Vorschreibung
force-pushed
the
ui-accelerators
branch
from
67fb1c2
to
b84c011
Compare
Aranud
approved these changes
Jun 7, 2024
|
|
The scope of this has never been sufficiently clarified while meta-chars to translation files were explicitly rejected. - I think it makes more sense to close this altogether as that would constitute a different approach altogether that someone can take up in the future and where it's unlikely these commits would be of any help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds Accelerator key functionality to ET's Menus, demo: https://www.youtube.com/watch?v=j33ZnEXoO54 by parsing
^_metacharacters out of UI texts, highlighting them and registering their action to the onKey handler.If the general idea of Accelerators are desirable and the current implementation suffices, I'd follow up filling in more Accelerators for UI Elements until it's in a release-able state.