Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in EDA tutorial #271

Closed
1 task done
ostreech1997 opened this issue Mar 18, 2024 · 0 comments · Fixed by #408
Closed
1 task done

Typo in EDA tutorial #271

ostreech1997 opened this issue Mar 18, 2024 · 0 comments · Fixed by #408
Labels
documentation Improvements or additions to documentation

Comments

@ostreech1997
Copy link
Collaborator

ostreech1997 commented Mar 18, 2024

🐛 Bug Report

There is a mistake In "Autocorrelation & partial autocorrelation" section. Text about ACF is wrong.

Autocorrelation function(AFC) describes the direct relationship between an observation and its lag. The AFC plot can help to identify the extent of the lag in moving average models.

Expected behavior

We must rewrite this section like this:

Autocorrelation function (ACF, $\rho(\tau))$ describes the relationship between $y_t$ and $y_{t+\tau}$. The ACF plot can help to identify the extent of the lag in moving average models.

Partial autocorrelation function (PACF, $\gamma(\tau))$ describes the relationship between $y_t$ and $y_{t+\tau}$ cleaned from the influence of $y_{t+1}, ..., y_{t+k-1}$. The PACF plot can help to identify the extent of the lag in autoregressive models.

How To Reproduce

Check tutorial in docs.

Environment

No response

Additional context

No response

Checklist

  • Bug appears at the latest library version
@ostreech1997 ostreech1997 added the bug Something isn't working label Mar 18, 2024
@d-a-bunin d-a-bunin added the documentation Improvements or additions to documentation label Mar 19, 2024
@d-a-bunin d-a-bunin removed the bug Something isn't working label May 29, 2024
@d-a-bunin d-a-bunin changed the title [BUG] Typo in EDA tutorial Typo in EDA tutorial May 29, 2024
ArtemLiA added a commit to ArtemLiA/etna that referenced this issue Jun 22, 2024
ArtemLiA added a commit to ArtemLiA/etna that referenced this issue Jun 27, 2024
1) Add space between "Autocorrelation function" and (ACF, pho(t)) and the same for PACF.
2) Add a link to the pull request in the CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants