Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pipelines docs and fix typo in EDA tutorial #408

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update pipelines docs and fix typo in EDA tutorial #408

wants to merge 8 commits into from

Conversation

ArtemLiA
Copy link

@ArtemLiA ArtemLiA commented Jun 22, 2024 •
edited
Loading

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

closes #372
closes #271

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@review-notebook-app Review Notebook App
Copy link

review-notebook-app bot commented Jun 24, 2024 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

d-a-bunin commented on 2024-06-24T08:43:23Z
----------------------------------------------------------------

Let's add space between "Autocorrelation function" and "(ACF, pho(t))". Same for PACF.

d-a-bunin
d-a-bunin requested changes Jun 24, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
etna/pipeline/autoregressive_pipeline.py Outdated Show resolved Hide resolved
etna/pipeline/pipeline.py Outdated Show resolved Hide resolved
@ArtemLiA
Update pipelines documentation (etna-team#372)
5910b9e 
1) Wrap step param into double `` in the AutoRegressivePipeline docs.
2) Fix problem with linting.
3) Add a link to the pull request in the CHANGELOG.md
@ArtemLiA
Fix typo in EDA tutorial (etna-team#271)
ff14d8c 
1) Add space between "Autocorrelation function" and (ACF, pho(t)) and the same for PACF.
2) Add a link to the pull request in the CHANGELOG.md
@d-a-bunin d-a-bunin self-requested a review June 28, 2024 06:54
@d-a-bunin
Copy link
Collaborator

Hi! You should resolve the merge conflict. Without that we can't rerun CI/CD.
Merge master into your branch in your local environment, solve the conflict and push the changes.

d-a-bunin
d-a-bunin reviewed Jul 1, 2024
View reviewed changes
etna/pipeline/pipeline.py Outdated Show resolved Hide resolved
d-a-bunin
d-a-bunin requested changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@d-a-bunin d-a-bunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at suggestions above.

d-a-bunin
d-a-bunin requested changes Jul 1, 2024
View reviewed changes
etna/ensembles/direct_ensemble.py Outdated Show resolved Hide resolved
etna/pipeline/autoregressive_pipeline.py Show resolved Hide resolved
etna/pipeline/pipeline.py Show resolved Hide resolved
@ArtemLiA
Fix typos with links in pipelines and ensemble docs
beaf8a8 
* Fix links in 'See Also' references in `Pipeline` docs
* Fix links in 'See Also' references in `AutoRegressivePipeline` docs
* Fix links in 'See Also' references in `DirectEnsemble` docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-bunin d-a-bunin d-a-bunin requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add strategy description to Pipeline docs Typo in EDA tutorial
2 participants
@ArtemLiA @d-a-bunin