-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add electricity
to internal datasets
#60
Conversation
🚀 Deployed on https://deploy-preview-60--etna-docs.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw the error with tests. I assume that the problem is in dataset size. Probably we should discuss that with other team members. Let's fix the other things first.
etna/datasets/internal_datasets.py
Outdated
os.makedirs(dataset_dir, exist_ok=True) | ||
with warnings.catch_warnings(): | ||
warnings.simplefilter("ignore") | ||
data = _download_dataset_zip(url=url, file_name="LD2011_2014.txt", sep=";") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What kind of warnings could you meet there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we load LD2011_2014.txt
via pd.read_csv
, it returns huge warning message like this:
DtypeWarning: Columns (1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18, ... ,368,369,370) have mixed types. Specify dtype option on import or set low_memory=False.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we specify dtypes somehow to avoid this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at comments above.
Before submitting (must do checklist)
Proposed Changes
Closing issues
Closes #51.