Add electricity to internal datasets
#60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-60--etna-docs.netlify.app |
d-a-bunin
requested changes
Aug 25, 2023
etna/datasets/internal_datasets.py
Outdated
| os.makedirs(dataset_dir, exist_ok=True) | ||
| with warnings.catch_warnings(): | ||
| warnings.simplefilter("ignore") | ||
| data = _download_dataset_zip(url=url, file_name="LD2011_2014.txt", sep=";") |
There was a problem hiding this comment.
What kind of warnings could you meet there?
There was a problem hiding this comment.
When we load LD2011_2014.txt via pd.read_csv, it returns huge warning message like this:
DtypeWarning: Columns (1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18, ... ,368,369,370) have mixed types. Specify dtype option on import or set low_memory=False.
There was a problem hiding this comment.
Can't we specify dtypes somehow to avoid this?
d-a-bunin
reviewed
Aug 28, 2023
d-a-bunin
reviewed
Aug 28, 2023
d-a-bunin
requested changes
Aug 28, 2023
d-a-bunin
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Closing issues
Closes #51.