Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't output default dummy process rows if user values are present? #174

Open
siddharth-krishna opened this issue Feb 2, 2024 · 3 comments

Comments

@siddharth-krishna
Copy link
Collaborator

I tried to implement (a), but on Demo 4 that still leaves us with 3 additional rows (the original ACT_COST = 1111 rows).

I am seeing them hard-coded in your code, def generate_dummy_processes. 😁 Apparently VEDA2 does not write out such "internal" ACT_COST default values for the dummy imports (VEDA-FE actually did).

Originally posted by @Antti-L in #173 (comment)

@olejandro
Copy link
Member

Yes, that probably was one of my very first contributions to the codebase. :-)

I can introduce a transform that cleans this up once we use sourcescen consistently.

@olejandro olejandro changed the title Don't output dummy process rows? Don't output default dummy process rows if user values are present? Feb 2, 2024
@olejandro
Copy link
Member

We should probably allow disabling dummy process generation, as well.

@Antti-L
Copy link

Antti-L commented Feb 2, 2024

Note also that the values are not consistent with what VEDA2 assumes, and so you could easily have "regressions" if TFM_UPD is used with multipliers. But I guess it doesn't matter too much...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants