lib/helpers: added support for zero 'ms' metrics #397

Merged
merged 2 commits into from Mar 9, 2014

Projects

None yet

3 participants

@SaveTheRbtz

Also added more tests for packet validity helper.

Pointed out by: @jeffyip in #382 (comment)

Alexey Ivanov added some commits Feb 23, 2014
Alexey Ivanov tests: improved tests for lib/helpers 5acff30
Alexey Ivanov lib/helpers: added support for null 'ms' metrics.
Pointed out by: jeffyip in #382 [1]

[1] etsy#382 (comment)
972993e
@anthroprose

+1

This is a pretty major metric skewer.

@anthroprose anthroprose referenced this pull request in WoLpH/python-statsd Mar 9, 2014
Merged

Fix for sending 0ms entries. #31

@mrtazz
Member
mrtazz commented Mar 9, 2014

Oh dammit, good catch @SaveTheRbtz. Thanks for fixing this!

@mrtazz mrtazz merged commit f27c349 into etsy:master Mar 9, 2014

1 check passed

Details default The Travis CI build passed
@anthroprose anthroprose referenced this pull request in jsocol/pystatsd Mar 9, 2014
Closed

Fix for wrapper function returning 0ms timings #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment