-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies version support #95
Conversation
Fix warnings in utilities tests
Use more appropriate variable name in filter_data_mode
Fix error raised in data_mode filtering. Now merge successively arrays by pair instead of 3 at a time
Refactoring of search functions in the wmo filter
improve docstrings make uri index store a property, not a method
as pointed by @quai20 in #63 (comment) a major change in fsspec occured after 0.8.3 that is a source of error for argopy caching functionalities: Check out the output of the following code for different fsspec versions: loader = ArgoDataFetcher(src='localftp', cache=True).float(2901623)
loader.load()
import pickle
fn = os.path.join(loader.fetcher.fs.fs.storage[-1], "cache")
cache = loader.fetcher.fs.fs.cached_files[-1]
if os.path.exists(fn):
with open(fn, "rb") as f:
cached_files = pickle.load(f)
else:
cached_files = cache
print('cached_files keys:')
[print("\t", k) for k in cached_files.keys()]; fsspec 0.8.3This is the version currently supported by argopy:
fsspec 0.8.4 > fsspec 2021.08.1Up to the last fsspec release, output is:
For some reasons fsspec does not prepend the path with the store protocol anymore, and this leads to FixThis is due to this peace of code being removed after 0.8.3 in fsspec/implementations/cached.py if not path.startswith(self.target_protocol):
store_path = self.target_protocol + "://" + path
else:
store_path = path This will be fixed by adding a test on fsspec version in our filesystems store_path method |
Clean logging details
Fix monitor status to use the local ftp validator instead of the option checker
Fix typo
changed domain and assume fsspec version compatibilitity
Fix bug avoiding argovis tests Refactor/rename some tests
with long api timeout
Increase api timeout to 3 mins
Remove cache from all index/erddap
https://docs.python.org/3/library/exceptions.html#NotImplementedError: "In user defined base classes, abstract methods should raise this exception when they require derived classes to override the method"
Fix bug in merged conflict
fix bug in abstract class test
fix bug in abstract method
Better list of dependancies in ci tests
to @quai20 for your review, this PR content: Addressed incompatibility with last versions of dependencies
Other changes
|
scikit-learn<=1.0, >=0.21 | ||
netCDF4<=1.5.7, >=1.3.1 | ||
dask<=2021.09.1, >=2.9 | ||
toolz<=0.11.1, >=0.8.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why we have toolz as a requirement, we should try to remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know about toolz yet, but packaging
seems to be missing from the requirements on my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed, toolz
does not seems to be necessary.
Fix bug in error raised with invalid ftp path
Will close #94