Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hide method to close notifications #27

Closed
OasisLiveForever opened this issue Aug 21, 2017 · 4 comments
Closed

Add hide method to close notifications #27

OasisLiveForever opened this issue Aug 21, 2017 · 4 comments

Comments

@OasisLiveForever
Copy link

Hi,

it would be great to hide programmatically all notifications of a group trough a hide method.
What do you think?

@euvl
Copy link
Owner

euvl commented Aug 21, 2017

Hi @OasisLiveForever,

Sounds reasonable, what's your use-case?

@OasisLiveForever
Copy link
Author

Hi,

sometimes I want to hide all notifications before navigating to a component.

Sometimes I want to have only one notification per group so I would like to clear all notifications of the group before showing a new notification (for this purpose it could be useful to have a max number of notification per group).

@euvl
Copy link
Owner

euvl commented Aug 21, 2017

Okay, hiding everything before doing navigation sounds pretty good, also your point about o have a max number of notification per group made me think that :max="10" prop would be also something useful.

Thanks, I will create corresponding issues for these 2 features and will try to spend some time on them next week 👍 👍

@euvl euvl added the question label Aug 21, 2017
This was referenced Aug 21, 2017
@euvl
Copy link
Owner

euvl commented Aug 24, 2017

Hey @OasisLiveForever, i've added both features that we discussed in version 1.3.3 👍

@euvl euvl added the LGTM label Aug 24, 2017
@euvl euvl closed this as completed Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants