Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promise:finally should reject if chained on a rejected Promise #59

Closed
evaera opened this issue May 28, 2021 · 1 comment
Closed

Promise:finally should reject if chained on a rejected Promise #59

evaera opened this issue May 28, 2021 · 1 comment
Labels
breaking change

Comments

@evaera
Copy link
Owner

evaera commented May 28, 2021

Currently :finally() resets the promise state, but this makes certain patterns hard. In JavaScript, promise.finally does not reset the success state, so we should probably mirror this behavior.

https://discord.com/channels/385151591524597761/402843211707449354/847622059064557638
@evaera evaera added the enhancement New feature or request label May 28, 2021
@evaera
Copy link
Owner Author

evaera commented Jul 7, 2021 •
edited
Loading

image
image

but it's not totally ignored:
image

this contradicts this existing test:
image

@evaera evaera mentioned this issue Jul 7, 2021
Closed
@evaera evaera added breaking change and removed enhancement New feature or request labels Jul 7, 2021
@evaera evaera closed this as completed in afc245c Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@evaera