Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contact add names not space sensitive #3

Open
Evande1 opened this issue Nov 11, 2022 · 1 comment
Open

contact add names not space sensitive #3

Evande1 opened this issue Nov 11, 2022 · 1 comment

Comments

@Evande1
Copy link
Owner

Evande1 commented Nov 11, 2022

  • in the event of a careless NUS student who adds an extra space bar
  • not mentioned in UG how it is handled

Steps:

  1. contact add n/John Doe p/98765432 e/johnd@example.com a/John street, block 123, 2. #01-01

  2. contact add n/John Doe p/98765432 e/johnd@example.com a/John #01-01

Screenshot 2022-11-11 at 4.32.15 PM.png

@soc-se-bot
Copy link

soc-se-bot commented Nov 14, 2022

Team's Response

This is not a functionality bug because names with multiple spaces work correctly with all other features of the application.

image.png

This is a feature flaw, as dictated by the module guidelines

image.png

It is valid for a contact to have multiple spaces in the name. Most address book and contact management applications allow you to add a contact with multiple spaces in the name.

It is up to the user discretion in creating contact names. As we have made almost all fields for contacts optional, the contact list can be repurposed to link tasks to 'contacts' that aren't people. In this case, having the freedom of multiple whitespaces is potentially helpful.

Either stance taken would result in inconvenience for a group of users. Since we do not want to restrict the user too much in the input, we decided to allow multiple spaces in names.

Regardless, this bug report is not in scope as it is an alternative implementation that we could consider in the future that would be not trivial to implement, and is not needed for this application to still be useful.

Items for the Tester to Verify

❓ Issue response

Team chose [response.NotInScope]

  • I disagree

Reason for disagreement: [replace this with your reason]
Name validation for spaces should still be checked in the above scenario, given the user might accidentally add 2 of the "same" person if they press the space-bar accidentally.


❓ Issue type

Team chose [type.FeatureFlaw]
Originally [type.FunctionalityBug]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants