Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize _pool_obj and _pool #144

Closed
3 of 7 tasks
JonathonMisiewicz opened this issue Sep 17, 2021 · 0 comments · Fixed by #153
Closed
3 of 7 tasks

Synchronize _pool_obj and _pool #144

JonathonMisiewicz opened this issue Sep 17, 2021 · 0 comments · Fixed by #153
Assignees
@JonathonMisiewicz
Labels
cleanup The code can be made a bit cleaner

Comments

@JonathonMisiewicz
Copy link
Contributor

JonathonMisiewicz commented Sep 17, 2021 •
edited
Loading

The AnsatzAlgorithm class has both a _pool_obj and a _pool, where _pool should just be the _pool_obj's list. This is redundant, and _pool should be eliminated.

  • Synchronize _pool_obj.terms_ and _pool... Currently de-sync'ed in PQE
  • Add magic methods to SQOpPool
    • __getitem__
    • __len__
    • __iter__
  • Remove all current calls to _pool with calls to _pool_obj (using the magic methods) or _pool_obj.terms()
  • Eliminate the _pool member of AnsatzAlgorithm
@JonathonMisiewicz JonathonMisiewicz added the cleanup The code can be made a bit cleaner label Sep 17, 2021
@JonathonMisiewicz JonathonMisiewicz self-assigned this Sep 17, 2021
This was referenced Sep 17, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JonathonMisiewicz JonathonMisiewicz

Labels
cleanup The code can be made a bit cleaner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup JonathonMisiewicz/qforte
1 participant
@JonathonMisiewicz