Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to json-patch 4.8.0 #93810

Merged
merged 1 commit into from
Aug 8, 2020
Merged

Update to json-patch 4.8.0 #93810

merged 1 commit into from
Aug 8, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Aug 8, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
Includes fix for evanphx/json-patch#108 and can be picked to 1.16-1.18

Does this PR introduce a user-facing change?:

NONE

/cc @logicalhan

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 8, 2020
@liggitt
Copy link
Member Author

liggitt commented Aug 8, 2020

/milestone v1.19

needed to fix a regression in json-patch equality comparison introduced in #92069

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 8, 2020
This was referenced Aug 8, 2020
Merged
Merged
@liggitt
Copy link
Member Author

liggitt commented Aug 8, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 8, 2020
@liggitt liggitt mentioned this pull request Aug 8, 2020
Merged
@dims
Copy link
Member

dims commented Aug 8, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Aug 8, 2020

cc @BenTheElder @aojea on network related flake on ipv6 for visibility: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/93810/pull-kubernetes-e2e-kind-ipv6/1292121554452221954

/retest

@k8s-ci-robot k8s-ci-robot merged commit 9b78bd5 into kubernetes:master Aug 8, 2020
@aojea
Copy link
Member

aojea commented Aug 8, 2020

cc @BenTheElder @aojea on network related flake on ipv6 for visibility: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/93810/pull-kubernetes-e2e-kind-ipv6/1292121554452221954

/retest

👀 🤔

2020-08-08T15:49:56.424709422Z stdout F [ERROR] plugin/errors: 2 nodeport-service.services-6689.svc.cluster.local.c.k8s-prow-builds.internal. A: dial udp 172.18.0.1:53: connect: network is unreachable

@aojea
Copy link
Member

aojea commented Aug 8, 2020

is this a new cluster? or are more jobs like this running in this cluster with this domain?
c.k8s-prow-builds.internal

@BenTheElder
Copy link
Member

BenTheElder commented Aug 9, 2020 •
edited
Loading

k8s-prow-builds is a cluster in github.com/kubernetes/k8s.io (the full config is there).
the job is running there

@liggitt liggitt deleted the json-patch-4.8.0 branch August 10, 2020 21:15
@lblackstone lblackstone mentioned this pull request Aug 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
5 participants
@liggitt @dims @k8s-ci-robot @aojea @BenTheElder