Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid keyframe results in (even more) invalid css #1959

Closed
sbfaulkner opened this issue Jan 25, 2022 · 0 comments
Closed

invalid keyframe results in (even more) invalid css #1959

sbfaulkner opened this issue Jan 25, 2022 · 0 comments

Comments

@sbfaulkner
Copy link
Contributor

while minifying css, we encountered another case where invalid css could stand to be handled a bit better

in this case, given...

@keyframes slidein {
  from {
    transform: translateX(0%);
  }

  to {
    transform: translateX(100%);
  }
	
  .invalid
}

@keyframes other {
  from {
    transform: translateX(100%);
  }

  to {
    transform: translateX(0%);
  }
}

minifying results in the following with the second keyframe being "merged" into the first and semicolons being added...

@keyframes slidein{0%{transform:translate(0)}to{transform:translate(100%)}invalid,other{from {transform: translateX(100%);};to {transform: translateX(0%);}}}
@evanw evanw closed this as completed in cccc6c6 Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant