runCallSync freezes because wasStopped is never set

[mhart]

It seems that wasStopped is never actually set, even though it's checked for in runCallSync:

esbuild/lib/npm/node.ts

Line 455 in 79a3512

if (wasStopped) throw new Error('The service was stopped');

This means that runCallSync calls will just freeze at

esbuild/lib/npm/node.ts

Line 474 in 79a3512

let status = Atomics.wait(sharedBufferView, 0, 0);

if there's actually a problem with the worker service starting

[mhart]

I think this is a relatively easy reproduction (Node.js v16.16.0, macOS M1)

$ npm install esbuild
$ node -p 'require("esbuild").formatMessagesSync([], { kind: "error" })'
[]

$ rm -rf node_modules/esbuild-darwin-arm64

$ node -p 'require("esbuild").formatMessagesSync([], { kind: "error" })'

# Freezes...

[mhart]

The actual circumstances that led to this are that I'm running VS Code on my Mac, but it appears to be an x64 build, running under Rosetta. So when I run node -p 'os.arch()' from the terminal in VS Code, it's outputting x64 – on the macOS terminal app, this is outputting arm64.

So running in VS Code's terminal, esbuild is looking for the wrong architecture. That's fine – but it's just freezing instead of actually throwing an error and exiting.