Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glob Entrypoints do not call onResolve #3317

Open
maths22 opened this issue Aug 15, 2023 · 1 comment
Open

Glob Entrypoints do not call onResolve #3317

maths22 opened this issue Aug 15, 2023 · 1 comment

Comments

@maths22
Copy link

maths22 commented Aug 15, 2023

When using a glob entrypoint through the javascript entrypoint, onResolve is not called in plugins on the resulting entrypoints. This breaks e.g. the sentry esbuild plugin which relies on onResolve being called before onLoad. Maybe this is expected behavior, but if it is it should probably be documented clearly.

@jed
Copy link

jed commented Sep 2, 2023

This also causes problems for WASM-based (ie, browser) implementations that use plugins to provide a filesystem. I realize this is tricky, but perhaps onLoad could return a set directory format in JSON (ie [{"name": "foo.txt", "type": "file"}, ...]) for paths ending in trailing slashes? ie, somehow let plugins return directory listings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants