Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI - deprecated function call: lti_build_standard_request() #25

Closed
danmarsden opened this issue Jul 28, 2020 · 2 comments
Closed

FYI - deprecated function call: lti_build_standard_request() #25

danmarsden opened this issue Jul 28, 2020 · 2 comments

Comments

@danmarsden
Copy link

since 3.7 - should be using: lti_build_standard_message instead.

note - this is not a blocker for approval in the plugins db.

@abias abias closed this as completed in d29cd89 Aug 17, 2020
@abias
Copy link
Member

abias commented Aug 17, 2020

Hey Dan,

you are absolutely right about this function. I think I missed this detail in https://tracker.moodle.org/browse/MDL-62599 where this function was deprecated as this fact was never mentioned in an upgrade.txt file.

The function is now replaced with the right one.

Cheers,
Alex

abias added a commit that referenced this issue Aug 17, 2020
abias added a commit that referenced this issue Aug 18, 2020
@galnapier
Copy link

galnapier commented Oct 16, 2020

As the original post by danmasrden says "since 3.7 - should be using: lti_build_standard_message instead" then this change is not 3.5 compatible and creates an error. Reverting back to lti_build_standard_request (seems to do the trick for the version downloaded from your 3.5 branch so have a fix meantime!).

function lti_build_standard_message is not in /mod/lti/locallib.php until Moodle 3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants