Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled Rejection (TypeError): Cannot read property 'isInstalled' of null #65

Closed
plxel opened this issue Apr 8, 2018 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@plxel
Copy link
Contributor

plxel commented Apr 8, 2018

Hello! Here we have await yarnPackageManager.isAvailable() and here we call checkAlreadyInstalledRecipes after 10 seconds timeout which call another function, which use project.packageManager.isInstalled. What if first await is not completed?

We got this:
image

I didn't dig deeply into Environment.hasCommand and why it is not return any result, but i got this error

I think it's not good idea to use timeout there

@eveningkid
Copy link
Owner

Thanks a lot for the input @plxel! You are right, it was a really bad idea to use setTimeout here.
I suggested a fix with #66, please git pull and let me know if you still run into any similar issues. :)
Thank you!

@eveningkid eveningkid self-assigned this Apr 9, 2018
@eveningkid eveningkid added the bug Something isn't working label Apr 9, 2018
@eveningkid
Copy link
Owner

If you run into the same issue again, please reopen the issue. I consider it as fixed for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants